Skip to content

Filter projects#16

Merged
biglovisa merged 2 commits into
mainfrom
lovisa/add-test-for-filtering
Feb 17, 2021
Merged

Filter projects#16
biglovisa merged 2 commits into
mainfrom
lovisa/add-test-for-filtering

Conversation

@biglovisa

@biglovisa biglovisa commented Feb 16, 2021

Copy link
Copy Markdown
Contributor

What

  • Add country/type filtering for Projects

Why

  • To make it easier to only retrieve the Projects that match your criteria.

SDK Release Checklist

  • Have you added an integration test for the changes?
  • Have you built the library locally and made queries against it successfully?
  • Did you update the changelog?
  • Did you bump the package version?
  • For breaking changes, did you plan for the release of the new SDK versions and deploy the API to production?

@biglovisa biglovisa self-assigned this Feb 16, 2021
@biglovisa biglovisa added the Needs Review The PR is ready to be reviewed label Feb 16, 2021
@biglovisa
biglovisa force-pushed the lovisa/add-test-for-filtering branch from 7f5bcaf to 28585bc Compare February 16, 2021 22:57
@biglovisa
biglovisa force-pushed the lovisa/add-test-for-filtering branch from 28585bc to 835ca57 Compare February 16, 2021 23:02
thdaraujo
thdaraujo reviewed Feb 17, 2021
View reviewed changes

@thdaraujo thdaraujo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the filter is getting added to all the endpoints, no?

Comment thread patch_api/api/estimates_api.py Outdated
"make",
"year",
"type",
"country",

@thdaraujo thdaraujo Feb 17, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 should this here too?
is the generator adding this filter parameter to all the endpoints or just projects?

@biglovisa biglovisa Feb 17, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated!

@biglovisa
biglovisa requested a review from thdaraujo February 17, 2021 16:39
@biglovisa
biglovisa force-pushed the lovisa/add-test-for-filtering branch from e1b6531 to 1915845 Compare February 17, 2021 16:51
@biglovisa biglovisa changed the title Add country/type filtering for Projects Filter projects Feb 17, 2021
thdaraujo
thdaraujo approved these changes Feb 17, 2021
View reviewed changes

@thdaraujo thdaraujo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@thdaraujo thdaraujo added Ready This PR is ready to ship! and removed Needs Review The PR is ready to be reviewed labels Feb 17, 2021
@biglovisa
biglovisa merged commit 2dde633 into main Feb 17, 2021
@biglovisa
biglovisa deleted the lovisa/add-test-for-filtering branch February 17, 2021 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@thdaraujo thdaraujo thdaraujo approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@biglovisa biglovisa

Labels

Ready This PR is ready to ship!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@biglovisa @thdaraujo